ssec-jhu / evolver-ng

Next gen eVolver controller for bioreactor project - wip
BSD 3-Clause "New" or "Revised" License
3 stars 0 forks source link

Add calibration interface #86

Closed jamienoss closed 1 week ago

jamienoss commented 2 months ago

Resolves #44 (partially, not inc #45)

Moved out of #47

The final design pattern is for the convert and fitting functionality to belong to the Transformer interface, and then the Calibrator interface takes these as config params for both input_transformer and output_transformer, along with this interface housing the runtime calibration procedure.

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 97.70115% with 4 lines in your changes missing coverage. Please review. Files Patch % Lines
evolver/calibration/interface.py 92.85% 4 Missing :warning:

:loudspeaker: Thoughts on this report? Let us know!

jamienoss commented 1 month ago

Update: We've discussed offline to adopt some of the design aspects I proposed a month or so ago, so this PR is still WIP.

The design points are: