Closed jamienoss closed 1 week ago
Attention: Patch coverage is 97.70115% with 4 lines in your changes missing coverage. Please review. |
Files | Patch % | Lines |
---|---|---|---|
evolver/calibration/interface.py | 92.85% | 4 Missing :warning: |
:loudspeaker: Thoughts on this report? Let us know!
Update: We've discussed offline to adopt some of the design aspects I proposed a month or so ago, so this PR is still WIP.
The design points are:
is_calibrated
semantics as this really isn't achievable - to really know whether calibration values are still accurate or not is not possible without running the calibration procedure to find out. Instead, we'll add timestamps to the calibration values and a mechanism to:
Output
models to always have populated both raw
and value
fields, currently, this is not possible since value
field(s) are those "calibrated" which may not have taken place yet. The Output
classes also belongs to the hardware interface and not the calibrator interface and thus shouldn't be entangled. The conversion of raw to device output unit should belong to the device, not the calibrator.
Resolves #44 (partially, not inc #45)
Moved out of #47
The final design pattern is for the convert and fitting functionality to belong to the
Transformer
interface, and then theCalibrator
interface takes these as config params for bothinput_transformer
andoutput_transformer
, along with this interface housing the runtime calibration procedure.