search

ssec-jhu / evolver-ng

Next gen eVolver controller for bioreactor project - wip
BSD 3-Clause "New" or "Revised" License
3 stars 0 forks source link

Dedupe accidental line copy #98

Closed jamienoss closed 1 month ago

jamienoss commented 1 month ago

Accidentally introduced in #73

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.71%. Comparing base (004812d) to head (1807f41).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #98 +/- ## ========================================== - Coverage 95.72% 95.71% -0.01% ========================================== Files 18 18 Lines 678 677 -1 ========================================== - Hits 649 648 -1 Misses 29 29 ``` | [Flag](https://app.codecov.io/gh/ssec-jhu/evolver-ng/pull/98/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ssec-jhu) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/ssec-jhu/evolver-ng/pull/98/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ssec-jhu) | `95.71% <ø> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ssec-jhu#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jamienoss commented 1 month ago

@amitschang Just found a couple more bugs in this func, so I've reverted the PR to draft and will re-work this PR to address those also. Stay tuned...

jamienoss commented 1 month ago

False alarm, it's elsewhere and can be another PR (#99).