search

ssec-jhu / evolver-ng

Next gen eVolver controller for bioreactor project - wip
BSD 3-Clause "New" or "Revised" License
3 stars 0 forks source link

Only shallow model dump from ConfigDescriptor.create to keep nested descriptors as instances and not dicts #99

Closed jamienoss closed 1 month ago

jamienoss commented 1 month ago

Discovered during #86 where hardware calibrator descriptors wouldn't get instantiated as they were being converted back to ordinary dictionaries during the nested creation process from Evolver.create().

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.73%. Comparing base (004812d) to head (f797043).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #99 +/- ## ========================================== + Coverage 95.72% 95.73% +0.01% ========================================== Files 18 18 Lines 678 680 +2 ========================================== + Hits 649 651 +2 Misses 29 29 ``` | [Flag](https://app.codecov.io/gh/ssec-jhu/evolver-ng/pull/99/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ssec-jhu) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/ssec-jhu/evolver-ng/pull/99/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ssec-jhu) | `95.73% <100.00%> (+0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ssec-jhu#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.