Update color limit sliders to update display instantly

ssec / sift

A visualization application for satellite imagery

http://sift.ssec.wisc.edu/

GNU General Public License v3.0

46 stars 14 forks source link

Update color limit sliders to update display instantly #324

Closed djhoese closed 2 years ago

djhoese commented 2 years ago

Closes #323

Turns out I implemented the previous way on purpose to avoid over taxing the CPU/GPU to draw the updates. However, looks like it handles this just fine. This PR updates the color limit sliders for the individual layers and for the RGB layers so that scrolling or clicking somewhere on the slider range will automatically the visual. Previously this required clicking and releasing the handle on the slider.

rayg-ssec commented 2 years ago

Reviewed code changes and spun it up on macOS. Very minor: scene_graph:change_layers_color_limits:L908 (and L913 for gamma) should be a debug (or maybe one step beyond) and not an info message after this change, since it gets pretty chatty during slider dragging.

djhoese commented 2 years ago

Should I also change the gamma and colormap to debug? They don't change as fast but they are the same level of change.

djhoese commented 2 years ago

+1.9% coverage. Woot woot.

All issues have been addressed. Merging now.