Open a8bit opened 7 years ago
I'm not opposed to the idea of a config file, but 512 bytes seems really small for an ARG_MAX. Also I normally get an error, something like argument too long. If it is ignoring things past a point, that seems odd. Could there be a space or something that isn't escaped?
Either way I can keep this as a feature request for a config file.
This line, does not put videos in ./snap
, they go to ./images
(the default)
/opt/retropie/supplementary/scraper/scraper -refresh -download_images -download_marquees -download_videos -console_img "3b,b,cart,s" -console_src "ss,gdb,ovgdb" -extra_ext "car,cue,pbp,chd,dat,svm,dat,z1,z2,z3,z4,z5,sh" -image_dir "./boxart" -image_path "./boxart" -image_suffix "" -img_format "png" -mame_img "s,t" -mame_src "adb,ss,gdb" -marquee_dir "./wheel" -marquee_format png -marquee_path "./wheel" -marquee_suffix "" -max_height 720 -max_width 720 -missing "./unscraped.txt" -skip_check -thumb_suffix "" -use_nointro_name false -video_dir "./snap" -video_path "./snap" -video_suffix "" -workers 4
That puts the -video_dir parameter over col 512. This line, works fine
/opt/retropie/supplementary/scraper/scraper -refresh -download_marquees -download_videos -console_img "3b,b,cart,s" -console_src "ss,gdb,ovgdb" -image_dir "./boxart" -image_path "./boxart" -image_suffix "" -img_format "png" -mame_img "s,t" -mame_src "adb,ss,gdb" -marquee_dir "./wheel" -marquee_format png -marquee_path "./wheel" -marquee_suffix "" -max_height 720 -max_width 720 -missing "./unscraped.txt" -skip_check -thumb_suffix "" -video_dir "./snap" -video_path "./snap" -video_suffix "" -workers 4
I removed
-download_images
-extra_ext "car,cue,pbp,chd,dat,svm,dat,z1,z2,z3,z4,z5,sh"
-use_nointro_name false
are any of those wrong?
if you change -use_nointro_name false
to -use_nointro_name=false
it works. I'm not sure why it does that for a bool flag.
Sheesh! OK keep this open as an enhancement request for the cfg file please
Is there any chance the command line option defaults could be loaded from a file so that only options that override the preferred defaults need to be on the command line?
I've been hitting the max length of the command line lately (is it 512?, options after ~500 are being ignored) and a lot of these options never change (paths to folders, source preferences, suffixes etc.) they would be better off somewhere else.
I'd suggest somewhere like ~/.scraper.cfg or something could hold all the defaults which could be user edited. This could be loaded in before command line options are processed, allowing command line to override pref file which overrides internal default.