sselph / scraper

A scraper for EmulationStation written in Go using hashing
MIT License
449 stars 88 forks source link

Not pulling correct md5??? #210

Open Vodkanakas opened 6 years ago

Vodkanakas commented 6 years ago

ive tried a few ways to scrape these roms and ive double checked that the file is in SS database with the same md5 crc and sha1 but yet they get a no hash found return. any idea on why?

sselph commented 6 years ago

I think I'm not sending a request if the hash is not in my no-intro set. I can probably send the request regardless since SS seems to have everything,

Vodkanakas commented 6 years ago

So like check the md5 to no intro set if false send anyways? But then checking the no intro would be redundant wouldn't it?

Vodkanakas commented 6 years ago

Maybe a perameter?

use_nointro_dat=false

Just assuming its a dat file lol

Vodkanakas commented 6 years ago

I may have found a work around that I didn't think about before. It requires expanding the Rom, patching with ips, then create a .bps file from the newly patched Rom. Then the no-intro can be used with the newly created .bps file and fceumm will soft patch it to be played with the patch. The scraping still does the checks for the no intro set that will pass and the roms stay in tact and original.

Vodkanakas commented 6 years ago

This does not help with rims that are not part of no intro sets such as bio hazard (unl), final fantasy vii (c), Dragon knife (unl) and such

sselph commented 6 years ago

I am actually sending this information so not sure why it isn't working. I'm actually attempting to fix an issue now where SS was responding with nonsense if the hash wasn't in their database.