ssg-aero / yams

Other
2 stars 2 forks source link

Compilation error of Python bindings on `linux-64` #5

Open adriendelsalle opened 2 years ago

adriendelsalle commented 2 years ago

Description

I got some compilation errors when compiling the Python bindings on linux-64:

ssg-aero commented 2 years ago

Did you try with gcc>=11.2?

I think it's a minimum requirement:

adriendelsalle commented 2 years ago

Yes I understand the perspective to get better performance using std::reduce. Maybe it would be a good thing to start a developer documentation to mention minimum version of gcc.

The binding of MeridionalGrid<T>::operator() still needs to be wrapped in a lambda. We could investigate later how to remove that limitation (returning a template parameter already works).

ssg-aero commented 2 years ago

Yes didn't find a workaround either for MeridionalGrid::operator(), so I've merged the PR