search

ssg / SimpleBase

.NET library for encoding/decoding Base16, Base32, Base58 and Base85.
Apache License 2.0
147 stars 21 forks source link

Fix Base32.TryDecode not considering padding. #14

Closed skwasjer closed 4 years ago

skwasjer commented 4 years ago

Fix for Base32.TryDecode not considering padding. Covered Crockford tests only at the moment. The decode test cases obviously don't use the padded parameter but this allows reuse of testData. Other approach would be separate testDataPadded or something but adds a whole lot more test code too which I did not like.

Let me know if this is ok with you, I can add coverage for other alphabets before merge.

See #13

ssg commented 4 years ago

LGTM. I'm merging this and drafting a new release. Feel free to add remaining tests in a separate PR. Thank you!