search

ssg8288 / Surviellance-Bomb-Diffusion-Robot

DEV_Script_WOC
MIT License
4 stars 8 forks source link

Code and documentation updated #26

Closed Pranjal-2001 closed 3 years ago

ssg8288 commented 3 years ago

issues #6 #2 solved

Zircoz commented 3 years ago

Use 1 label for level only

ssg8288 commented 3 years ago

Use 1 label for level only

FYI he submitted this PR for two issues having different labels which you can verify under the closed issues ...thus, I had to close the pull request all together with the issues linked #6 and #2. Thank you

Zircoz commented 3 years ago

@ssg8288 not saying that his work is invalid but DWOC's backend will only pickup one of the level label imo. (though ask them if my intuition is right, and if it is just ask him to do another PR only for representation and assign one of the level labels to it)

ssg8288 commented 3 years ago

@ssg8288 not saying that his work is invalid but DWOC's backend will only pickup one of the level label imo. (though ask them if my intuition is right, and if it is just ask him to do another PR only for representation and assign one of the level labels to it)

@Zircoz well well this will be a tedious task for him then lmfao XD....I got you what you are tryna say it hit me too while I was merging the request but I thought since, I linked two issues separately then it should not effect much well I will first get it confirmed from the core team then will ask him if this needs to be sorted thanks for pointing it out.

Zircoz commented 3 years ago

Issues are not checked by backend, labels on issues are just to make it more descriptive for contributors. @ssg8288

ssg8288 commented 3 years ago

@Pranjal-2001 this msg is in regards for your recent commit and PR since you merged the code and documentation altogether i linked the issues and level tags in the same pull requests but this will be a issue for you on calculating your points thus i would ask you to just create another pull request for either the code or document by adding a small change or comments and pull a request which will be merged against of the issue which will lead to your points then hope you understand

Pranjal-2001 commented 3 years ago

Okay code is level 5 so we will let it be like that. I will make a few changes in documentation.

On Wed, 13 Jan 2021, 1:15 am Shubhamsengupta, notifications@github.com wrote:

@Pranjal-2001 https://github.com/Pranjal-2001 this msg is in regards for your recent commit and PR since you merged the code and documentation altogether i linked the issues and level tags in the same pull requests but this will be a issue for you on calculating your points thus i would ask you to just create another pull request for either the code or document by adding a small change or comments and pull a request which will be merged against of the issue which will lead to your points then hope you understand

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ssg8288/Surviellance-Bomb-Diffusion-Robot/pull/26#issuecomment-758892901, or unsubscribe https://github.com/notifications/unsubscribe-auth/APBWVG6OTFWPKQJ744F5DZ3SZSRF5ANCNFSM4V6WOKHQ .