search

ssg8288 / Surviellance-Bomb-Diffusion-Robot

DEV_Script_WOC
MIT License
4 stars 8 forks source link

Minor Changes or bugs #8

Closed ssg8288 closed 3 years ago

ssg8288 commented 3 years ago
akrish4 commented 3 years ago

Hi @ssg8288
there is a typo error / bug in the contributing file , the link to code of conduct file is redirected to some other's repository which actually is a forked repository of this project.

kindly assign me this issue @ssg8288

the below shown is the image of contributing file.

bomb_robot1

the below shown image is the code of conduct file.

bomb_robot2

ssg8288 commented 3 years ago

Hi @ssg8288 there is a typo error / bug in the contributing file , the link to code of conduct file is redirected to some other's repository which actually is a forked repository of this project.

kindly assign me this issue @ssg8288

the below shown is the image of contributing file.

bomb_robot1

the below-shown image is the code of conduct file.

bomb_robot2

Thanks for pointing this out @akrish4 I have assigned you the issue kindly fork and star it before you move further with it. Goodluck. Kindly, make a note of changes made in the comment while you make a PR.

akrish4 commented 3 years ago

sure @ssg8288

akrish4 commented 3 years ago

Hi @ssg8288

i found some typo in this README, let me know i need to rectify it or not , is it a link ? or image ?

readme_bomb_robot1

and this

readme_bomb_robot2

these are links actually not a image link (jpeg/png) , so it won't display a image , only thing can be done is to remove that and it would look like this

readme_bomb_robot3

let me know whether to need to update like above image or leave it as it is @ssg8288

ssg8288 commented 3 years ago

Hi @ssg8288

i found some typo in this README, let me know i need to rectify it or not , is it a link ? or image ?

readme_bomb_robot1

and this

readme_bomb_robot2

these are links actually not a image link (jpeg/png) , so it won't display a image , only thing can be done is to remove that and it would look like this

readme_bomb_robot3

let me know whether to need to update like above image or leave it as it is @ssg8288

Yes, these are links not images and your update is fine no problem you can update it @akrish4 👍

akrish4 commented 3 years ago

ok thank you @ssg8288

akrish4 commented 3 years ago

11

ssg8288 commented 3 years ago

11

is this issue resolved @akrish ??

akrish4 commented 3 years ago

11

is this issue resolved @akrish4 ??

yes this is the issue you have just merged (issue resolved) and you have tagged wrong username (Akrish)

ssg8288 commented 3 years ago

11

is this issue resolved @akrish4 ??

yes this is the issue you have just merged (issue resolved) and you have tagged wrong username (Akrish)

so should I close this issue as well cuz you created a new issue for it which I just merged.

ayee pardon me ;)

akrish4 commented 3 years ago

11

is this issue resolved @akrish4 ??

yes this is the issue you have just merged (issue resolved) and you have tagged wrong username (Akrish)

so should I close this issue as well cuz you created a new issue for it which I just merged.

ayee pardon me ;)

no , i have opened only 1 issue and this is the only issue which i have linked /referneced in the pull request which you have merged so u need to close this issue which the bug is resolved now, so you can close.

@ssg8288

ssg8288 commented 3 years ago

11

is this issue resolved @akrish4 ??

yes this is the issue you have just merged (issue resolved) and you have tagged wrong username (Akrish)

so should I close this issue as well cuz you created a new issue for it which I just merged. ayee pardon me ;)

no , i have opened only 1 issue and this is the only issue which i have linked /referneced in the pull request which you have merged so u need to close this issue which the bug is resolved now, so you can close.

@ssg8288

okay great

ssg8288 commented 3 years ago

The above issue was resolved #11 in this new committed issue and is a duplicate of that same issue hence, I have closed this issue and labelled both the issues with same tags |dwoc |dwoc2020 |level3 |bug