search

sshado / Aphelion-Code

The code for Baystation12's branch of SS13
http://baystation12.net/
Other
4 stars 8 forks source link

Modular firearms - MFCS #186

Open BlueNexus opened 9 years ago

BlueNexus commented 9 years ago

//THIS IS HEAVILY WORK IN PROGRESS//

The MFCS allows players to construct and disassemble firearms using a wide variety of components, allowing the player to customise recoil, accuracy, projectile type, fire rate and mode, projectile speed, loading method and more. All firearms in the game will be replaced with these modular variants. MFCS Firearms may be constructed by R&D or anybody who gets a hold of the parts, however the final part will come in a lock box, to prevent them being made and used for grief. This will hopefully give research something interesting to do, and will add a lot of depth to the firearms in the game. Keep in mind, this project is massively work in progress. Feedback would be appreciated, however.

Current build - 215

MistakeNot4892 commented 8 years ago

Cirra asked me for critique, ftr, this isn't me randomly deciding to talk shit on another codebase's PRs.

A lot of the code here seems bloated or redundant, I feel like you could make good use of associative lists for all the various kinetic/ballistic/etc checks rather than having so much boilerplate for each individual var.