Recent change in JavaFX (17-ea+2) breaks JFXProgressBar

sshahine / JFoenix

JavaFX Material Design Library

MIT License

6.29k stars 1.06k forks source link

Recent change in JavaFX (17-ea+2) breaks JFXProgressBar #1187

Open nemphys opened 3 years ago

nemphys commented 3 years ago

Due to this change: https://github.com/openjdk/jfx/commit/473382443c0a52be1307b762deecb37a17305a47, NodeHelper.treeShowingProperty() is no longer available and therefore JFXProgressBarSkin throws exceptions when trying to use it. Since this upstream change is a (long awaited) performance improvement, it would make sense to fix this.

palexdev commented 3 years ago

@nemphys HI, if you need a working progress bar you can check my project here MaterialFX

sshahine commented 3 years ago

@nemphys thank you pointing out the issue 👍

RationalityFrontline commented 3 years ago

I've made a workaround for JavaFx17：

implementation("org.rationalityfrontline.workaround:jfoenix:17.0.1")

Sources: https://github.com/RationalityFrontline/JFoenix/tree/JFoenix-17.0.0

FelipeAumannRS commented 2 years ago

Please solve that. It`s time already.