search

sshane / openpilot

DOES NOT SUPPORT COMMA 3X - Stock Additions (0.8.14): 3/automatic following distance profiles, customizable fork params with opEdit, and a smoother longitudinal experience for TSS2 Toyotas
MIT License
220 stars 86 forks source link

`upload_on_hotspot` does nothing #496

Closed khoi closed 2 years ago

khoi commented 2 years ago

Describe the bug https://github.com/sshane/openpilot/blob/210da470fc78cce48f38691c2e355727f24e5bc2/selfdrive/loggerd/uploader.py#L30

the variable is set but I don't see it's being used anywhere?

sshane commented 2 years ago

You're right, missed removing it. In Android 12 (and 11?) you can't detect if you're on a hotspot based on IP alone as they're randomized, so it makes it difficult to keep up with this. Will remove unless I find another way to detect hotspot

sshane commented 2 years ago

503