sshane / openpilot

DOES NOT SUPPORT COMMA 3X - Stock Additions (0.8.14): 3/automatic following distance profiles, customizable fork params with opEdit, and a smoother longitudinal experience for TSS2 Toyotas
MIT License
220 stars 85 forks source link

Longcontrol: remove starting state #542

Closed sshane closed 2 years ago

sshane commented 2 years ago

No point in having a starting state which "releases brake." PID can do the same, and we don't have the effect of starting moving the output_accel to some arbitrary number only for PID control to jump the output to some other value. In Toyota stock ACC, the accel request jumps to whatever their controller wants near immediately.