search

sshaw / build-status

Emacs minor mode that monitors and shows a buffer's build status in the mode line.
27 stars 2 forks source link

Set the Travis CI domain via a variable #9

Closed porras closed 5 years ago

porras commented 5 years ago

There is no way to tell from the local .travis.yml file if the project is hosted on .org or .com. One could of course fallback to the other one if the first fails, but that'd be probably inefficient, and still leaves the problem of Enterprise. So I thought this would be the simpler way of doing it.

I'm successfully using my fork with several projects in .org and .com, I didn't test in enterprise though. I think it should work, if you point to the right domain.

Note: While trying that this worked with different projects (I have some in .org and some in .com), I discovered a small bug, which I fixed in a separate PR for easier review: #8 (but I based this branch in that one).

sshaw commented 5 years ago

Hi, thanks for this. Can you remove 99f378c from this PR since it's included in #8?

porras commented 5 years ago

Sure! I based this PR on #8 because for my usecase it's useless without it, but it makes total sense to review and merge separately, since this one is much simpler than the other one and you might want to give a closer look.

I just made it.

sshaw commented 5 years ago

Great, thanks! It's not often I get to mark something off a TODO list due to someone else's PR. 🎉💪

The other commit requires additional review but this one is good to go!