search

sshaw / ddex

DDEX metadata serialization for Ruby
https://metadatagui.com
52 stars 41 forks source link

Fix for rack content length #18

Closed millar closed 5 years ago

millar commented 5 years ago

.bytesize no longer exists in Rack::Utils but it is part of the Ruby String API.

sshaw commented 5 years ago

Thanks for the PR. Glad to see someone is actually using the middleware 😀. Do you mind sharing what/how you're using it? (Just curious).

Supporting Ruby 1.8 is not necessary anymore so this should do.

Can you please squash into a single commit?

Also note that specs are failing.

millar commented 5 years ago

No problem – I've squashed the commits.

We're using this because our stack is python but there are no good, up to date libraries to do this in python. Running this as a service and parsing JSON in python works well for us.

The specs are failing because the latest version of bundler (2.0) doesn't support ruby < 2.3. I'm not sure what the best solution to that is, unfortunately.

sshaw commented 5 years ago

Thanks!