search

sshaw / ddex

DDEX metadata serialization for Ruby
https://metadatagui.com
52 stars 41 forks source link

Fallback to checking the version directly when MessageSchemaVersionId is invalid #6

Closed parndt closed 9 years ago

parndt commented 9 years ago

We were getting XML files from suppliers like instance3.xml with the MessageSchemaVersionId="3.7" but the library still seemed to nearly detect the version correctly.

Let me know if this is wrong or bad or anything. :smile:

sshaw commented 9 years ago

Thanks for this. You'd think that somewhere in those gargantuan schemas they would have made MessageSchemaVersionId a xsd:restriction of sorts.

No one over at the implementers form seems to be interested or at least have a reason or solution.

parndt commented 9 years ago

@sshaw you'd think so!!! I've updated the PR as you wanted.

parndt commented 9 years ago

hahah.. that's hilarious; I had that tab open already! I just now put two and two together and realised it was you writing the post. Nice one.

sshaw commented 9 years ago

Thanks again. I've just released v0.0.2 with this addition: https://rubygems.org/gems/ddex.

parndt commented 9 years ago

Magnificent. Thanks for your prompt attention! We've switched to the new version.