Added v312 for 2010/ern-main/312

sshaw / ddex

DDEX metadata serialization for Ruby

https://metadatagui.com

53 stars 38 forks source link

Added v312 for 2010/ern-main/312 #8

Closed parndt closed 1 year ago

parndt commented 9 years ago

@sshaw this seems to work.. is there anything obviously bad about it?

parndt commented 9 years ago

@sshaw hey, sorry to bother you, but what do you think about these changes?

sshaw commented 9 years ago

Oh what what what from may 21, sorry must have missed the :octocat: alert. The diff will kill my weak cell connection but ill take a look when im back to the motherland ~6 days. Are there tests? Need tests.

parndt commented 9 years ago

Alas, it is lacking tests. Remind me if I still haven't done this by the time you come to review it properly. Enjoy your weak cell connection :palm_tree:

sshaw commented 9 years ago

Check the contrib doc for details on test creation.

sshaw commented 9 years ago

Oh, now that I'm back to high speed land, I see that I didn't miss this, but I didn't merge back in May do to lack of tests :no_good:.

Other than that things seem to be okay. But please try to add them, let me know if you have any questions -I'm here to help! :muscle:

parndt commented 9 years ago

@sshaw yup - fair enough!

sshaw commented 1 year ago

Closing. We're on 4.3 now so should not be an issue :)