sshaw / git-link

Emacs package to get the GitHub/Bitbucket/GitLab/... URL for a buffer location
399 stars 74 forks source link

Add support for Magit-Blob buffers #61

Closed Miciah closed 5 years ago

Miciah commented 5 years ago

Use the correct branch or commit when the current buffer is visiting a blob using Magit.

Miciah commented 5 years ago

I noticed that it does not include the line numbers when linking from a blob.

Thanks for noticing this, I had missed it. I'll look into it.

Miciah commented 5 years ago

I believe I fixed the missing line numbers. (I'm curious why the when form that I modified is needed at all.)

sshaw commented 5 years ago

Great, thanks again!

sshaw commented 5 years ago

(I'm curious why the when form that I modified is needed at all.)

Because one can link to a file in a dired buffer or in magit buffers and in these cases we don't have an actual file and therefore cannot/should not get the region.