sshaw / git-link

Emacs package to get the GitHub/Bitbucket/GitLab/... URL for a buffer location
399 stars 74 forks source link

Travis CI coverage for Emacs 27; Travis CI uses Nix #74

Closed peterbecich closed 4 years ago

peterbecich commented 4 years ago

Uses https://github.com/purcell/nix-emacs-ci now

sshaw commented 4 years ago

Ooooh Nix, nice...

peterbecich commented 4 years ago

@sshaw , please review

sshaw commented 4 years ago

@peterbecich thanks a lot. I recently updated Travis CI config for rvm.el and saw that the Old Method ™️ didn't have the latest version so definitely will be using this there too!

Just one request: can you squash into a single commit?

Thanks! 💪

peterbecich commented 4 years ago

@sshaw very good, done

sshaw commented 4 years ago

One thing I just noticed is that we explicitly call make build. Since make test has build as a prerequisite, is there a reason to call it explicitly?

Merging regardless!