search

sshaw / git-link

Emacs package to get the GitHub/Bitbucket/GitLab/... URL for a buffer location
399 stars 74 forks source link

Adds AWS CodeCommit support #91

Closed kriyative closed 2 years ago

kriyative commented 2 years ago

This PR adds support for extracting git-links in AWS CodeCommit repositories.

sshaw commented 2 years ago

Hi, thanks for the PR. I have not heard of AWS CodeCommit, will check it out!

Could you please squash this into a single commit? Afterwards I will have a looksy.

kriyative commented 2 years ago

@sshaw - done. Cheers.

sshaw commented 2 years ago

Hi, sorry for the delay. Has some issues setting up a repo to test: you still must create HTTP git credentials after creating/adding the appropriate IAM user roles.

I did notice that AWS requires the full commit SHA when linking to a commit. For example C-c g l on a SHA in magit results in an error since the SHA is only 7 chars.

Maybe an error should be signaled in git-link-commit-codecommit is SHA length is < 7?