search

sshivaditya2019 / test-public

0 stars 0 forks source link

Plugin chain issue #181

Closed sshivaditya2019 closed 1 week ago

sshivaditya2019 commented 1 month ago

right now it's messy that every plugin posts their own comments. It allows for flexibility but I think it's a bad idea for it to be the main way.

I propose we have a method that lets the developer pass in the comments data and the kernel posts the comment on the behalf of the plugin.

Great example of a plugin comment that should be inside of the /start message.

I envision it can just append this below the /start table basically.

Make it so plugins can append if ran in a chain. This was discussed before by leveraging KV run ID in the metadata and such.

Originally posted by @ubiquity-os-betas in ubiquity-os-marketplace/text-conversation-rewards#113 (comment)

[!CAUTION] This issue may be a duplicate of the following issues:

[!CAUTION] This issue may be a duplicate of the following issues:

sshivaditya2019 commented 1 week ago

@ubosshivaditya can you explain the linked issues ?

test-app-ubo[bot] commented 1 week ago

Certainly! The linked issues focus on improving how plugin-generated comments are managed within your repository to enhance clarity and maintainability. Here's a summary of each:

  1. Consolidate comments (#210)
    This issue addresses the clutter caused by multiple plugins posting individual comments. The proposed solution is to consolidate these comments into a single, managed comment, reducing noise and improving readability.

  2. Consolidated Comment Per Plugin Chain Run ID (#178)
    Here, the discussion revolves around using unique run IDs from Cloudflare KV to organize comments generated by each plugin. This method ensures that comments are grouped appropriately, making it easier to track and manage plugin interactions.

  3. Consolidated Comment Per Plugin Chain Run ID (#180)
    Similar to issue #178, this task emphasizes appending comments within plugin chains using metadata like plugin IDs. The goal is to allow plugins to add their sections without interfering with each other, maintaining a structured comment format.

  4. Consolidated Comment Per Plugin Chain Run ID (#179)
    This issue further explores the implementation details of consolidating plugin comments. It discusses parsing section separators with regex to identify and manage each plugin's output effectively.

Common Theme Across Issues:
All these issues aim to streamline the process of handling comments from multiple plugins by centralizing them under a unified structure. By doing so, it enhances the scalability of the system, ensures type safety, and maintains a clean and organized comment history within issues and pull requests.

If you have any specific questions about these issues or need further clarification on their implementations, feel free to ask!