Closed realvizu closed 7 months ago
It looks good to me! But I need more time to test it!
Do you have a specific function in mind that you want to implement using this functionality? Did you see that it can be useful in https://github.com/dotnet/Docker.DotNet/issues/540
Those tests work on my machine.
It looks good to me! But I need more time to test it!
Do you have a specific function in mind that you want to implement using this functionality? Did you see that it can be useful in dotnet/Docker.DotNet#540
I had a very specific use case: I had to call some legacy system that is implemented as a set of SSH commands and one of the commands requires sending a file via input stream. These changes made it work.
Thanks a lot @WojciechNagorski and @Rob-Hague for the comments and suggestions!
Shall I do a squash+rebase onto develop before merging the PR?
It will be merged with "Squash and merge" so it is not necessary
(it requires a CODEOWNERS approval before it can merge)
There is a build problem:
C:\projects\ssh-net\test\Renci.SshNet.IntegrationTests\SshClientTests.cs(37,33): error CS7036: There is no argument given that corresponds to the required parameter 'offset' of 'Stream.Write(byte[], int, int)' [C:\projects\ssh-net\test\Renci.SshNet.IntegrationTests\Renci.SshNet.IntegrationTests.csproj::TargetFramework=net48]
This issue has been fixed in the 2024.0.0 version.
Changes:
I you have recommendations for further unit tests, please advise.
I started the work by trying to run all unit tests on my dev machine to see if they all pass. Unfortunately a lot of them failed, so I had to make the following modifications (see the changes in my first commit in this PR):
If you know a better fix for any of the above modifications, please advise.