Handle timeout correctly on Socks5 Proxy

sshnet / SSH.NET

SSH.NET is a Secure Shell (SSH) library for .NET, optimized for parallelism.

http://sshnet.github.io/SSH.NET/

MIT License

3.88k stars 917 forks source link

Handle timeout correctly on Socks5 Proxy #1342

Closed BoronBGP closed 1 month ago

BoronBGP commented 3 months ago

Currently when using the Socks5 proxy there are issues with timeouts when a socks5 proxy server takes a long time to respond to a connection request (e.g. when a host is unreachable). This PR adds a timeout to all socket read calls as it standard with the Socks4Connector and a test for this.

WojciechNagorski commented 3 months ago

Looks great! I need to test this.