search

sshnet / SSH.NET

SSH.NET is a Secure Shell (SSH) library for .NET, optimized for parallelism.
MIT License
3.87k stars 915 forks source link

git: checkout cs files with crlf #1372

Closed mus65 closed 2 months ago

mus65 commented 2 months ago

Currently, when you clone the repository on a Linux machine, all cs files have the wrong line endings. The .editorconfig file enforces crlf, but git will checkout the files with the default OS file encoding by default (lf).

This causes a dotnet format whitespace --verify-no-changes to complain about the line endings on a fresh working copy.

Tell git to checkout *.cs files with crlf to fix this. Note that existing linux working copies would need to run the following to fix the newlines after pulling in this change: git rm -rf --cached . && git reset --hard HEAD.

I noticed this while looking into enforcing formatting in CI, but that's for a separate PR.

Rob-Hague commented 2 months ago

Fine for me either way, just wondering if it makes more sense to stop enforcing crlf in the .editorconfig? i.e. delete this line instead

https://github.com/sshnet/SSH.NET/blob/7b58819537798bec53e4193a3e5f395bcf018023/.editorconfig#L10

For reference, the dotnet/runtime .editorconfig and .gitattributes:

https://github.com/dotnet/runtime/blob/main/.editorconfig https://github.com/dotnet/runtime/blob/main/.gitattributes

mus65 commented 2 months ago

Yeah, I think that makes even more sense, thanks. Pushed.