fix flaky SFTP file time tests

sshnet / SSH.NET

SSH.NET is a Secure Shell (SSH) library for .NET, optimized for parallelism.

MIT License

3.87k stars 915 forks source link

fix flaky SFTP file time tests #1414

Closed mus65 closed 1 week ago

mus65 commented 3 weeks ago

These asserts currently assume that DateTime.Now and the creation timestamp on the server happen within the same second.

Note that I didn't change the asserts below where an explicit timestamp is set. From my understanding, these should not be affected.

example: https://ci.appveyor.com/project/drieseng/ssh-net/builds/49850731/job/u6lk0cyipbxkp4jd

Rob-Hague commented 3 weeks ago

Thanks, I'm pretty sure I just deleted these asserts in some similar tests but maybe I missed some. I'm out for the next week or so so may not come back until then

Rob-Hague commented 2 weeks ago

Yeah, let's just delete them. The real asserts are a few lines lower.

mus65 commented 1 week ago

I removed them.