search

ssi-anik / amqp

php-amqplib wrapper that eases the consumption of RabbitMQ. A painless way of using RabbitMQ
https://packagist.org/packages/anik/amqp
MIT License
134 stars 23 forks source link

Support for PHP 8 #17

Closed insanebits closed 3 years ago

insanebits commented 3 years ago

Currently only php 7 is supported and php-amqplib already seems to support php 8, so there shoudn't be any big issues with the upgrade.

EDIT:

It seems the issue is amqplib being locked at 2.9 which does not support PHP 8.

There was another related issue which was closed:

https://github.com/ssi-anik/amqp/issues/16

kiwina commented 3 years ago

Where are you getting php7 support only? i got it installed on 8 without any problems

insanebits commented 3 years ago

I'm not sure how but according to packagist: https://packagist.org/packages/anik/amqp

php-amqplib/php-amqplib: ^2.9 !=2.12.0

Where amqplib: https://packagist.org/packages/php-amqplib/php-amqplib#v2.12.3

Is locked to php <8.0

This means that version 3.0 is not allowed and thus only php 7 is supported.

nicopenaredondo commented 3 years ago

@kiwina how did you install it using PHP 8 ? i'm getting similar error with @insanebits

ssi-anik commented 3 years ago

Sorry guys to reply this late. I will check the PR sent by insanebits and add changes if required accordingly and inform here.

ssi-anik commented 3 years ago

Merged @insanebits 's PR #18. Tagged with v1.6. Thanks all.