search

ssi-anik / elastic-apm-php

elastic/apm-agent-php wrapper to push PHP application transactions to APM Server
https://bit.ly/300vUkX
MIT License
16 stars 9 forks source link

fixing usage of setLabel #5

Closed graemlourens closed 3 years ago

graemlourens commented 3 years ago

setLabel has been moved to context() in the latest v1.0.0 beta1. See release notes (breaking changes) https://www.elastic.co/guide/en/apm/agent/php/current/release-notes-v1.0.0-beta1.html

P.s. is this package still under active development or is there a replacement / continuation? I'd love to see this one evolve and am happy to participate in future.

ssi-anik commented 3 years ago

Thanks for your contribution. I'm not maintaining this project for the last few months. And as the agent itself is in beta and discourages use in production I'd like to keep it unmaintained till it's released. If you think you can work on it, I can surely make you the maintainer.

graemlourens commented 3 years ago

@ssi-anik I understand. Until elastic releases production version (and adds lots of missing features like adding custom context, user info etc) we'll just be using it for load-tests and analysis on integration environments. For now what you have in this package is already very good, the only thing is this setLabel that causes fatals. If you could merge at least this and release new version, that would be fantastic.

If in future we would need to add lots more, we'll probably then continue directly on our fork and get back to you at a later stage.

ssi-anik commented 3 years ago

Let me know if this helps. Otherwise, I'll try to merge. https://medium.com/swlh/using-your-own-forks-with-composer-699358db05d9

graemlourens commented 3 years ago

@ssi-anik Great article, for sure we can go down our own path if you do not have time currently to merge PR's Lets catch up again as soon as elasticsearch has released final version and officially recommends it for production, to see if we would like to keep one repo in sync.

ssi-anik commented 3 years ago

Much appreciated. <3

nerijuso commented 3 years ago

Hi. When you are planning to merge this fix? :)

ssi-anik commented 3 years ago

Whoever is coming to this issue, please follow this article: https://medium.com/swlh/using-your-own-forks-with-composer-699358db05d9 and graemlourens's repository: https://github.com/graemlourens/elastic-apm-php Merging these PRs will not solve these issues soon as the dependency is not stable yet. wait till the apm agent becomes stable and we'll decide after that.

benpoulson commented 3 years ago

Looks like we're now at a stable 1.0.0 release.

ssi-anik commented 3 years ago

@benpoulson the agent already supports L6. Let's see if we can contribute there rather than maintaining a separate repo. I'll try my best if I can help them.

image