ssi-schaefer / lcdsl

Eclipse Launch Configuration DSL (Xtext based)
Eclipse Public License 1.0
23 stars 12 forks source link

fix org.eclipse.core.runtime startlevel to default. #47

Closed jukzi closed 2 years ago

jukzi commented 2 years ago

see PluginConfigurationSection.getBundlesWithStartLevels()

With level 0 an error can occur at startup: java.lang.IllegalArgumentException: Cannot set the start level to less than 1: 0 at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.setStartLevel(ModuleContainer.java:1596) at org.eclipse.osgi.container.ModuleContainer.setStartLevel(ModuleContainer.java:1182) at org.eclipse.osgi.container.Module.setStartLevel(Module.java:259) at org.eclipse.core.runtime.adaptor.EclipseStarter.installBundles(EclipseStarter.java:1000) at org.eclipse.core.runtime.adaptor.EclipseStarter.loadBasicBundles(EclipseStarter.java:596) at org.eclipse.core.runtime.adaptor.EclipseStarter.startup(EclipseStarter.java:331) at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:251) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.base/java.lang.reflect.Method.invoke(Method.java:566) at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:659) at org.eclipse.equinox.launcher.Main.basicRun(Main.java:596) at org.eclipse.equinox.launcher.Main.run(Main.java:1467) at org.eclipse.equinox.launcher.Main.main(Main.java:1440)

mduft commented 2 years ago

Is 'default' early enough? I think the 0 start-level was there for some reason. May be related to RAP application, etc. pp. Please thoroughly test this..

jukzi commented 2 years ago

Michi tested it sucessfully. See also PluginConfigurationSection.getBundlesWithStartLevels() that it should be default. It probably only was set to "0" because in the PDE UI there is not difference between 0 and default.