search

ssilverm / pimame-8

33 stars 6 forks source link

mame_install.py unexpected behaviour if no Internet connection. #2

Closed s-hirvonen closed 10 years ago

s-hirvonen commented 10 years ago

Steps to reproduce:

  1. Disconnect all network connections
  2. Install MAME from the menu
  3. Wait for the script to finish

Expected result: Expected the script to either fail or do nothing, and let me try again later when I have a network connection and all wget targets can be reached.

Actual result: MAME4All and AdvanceMAME are not installed, but the menu thinks they are.

mame_install.py script runs and most of the commands obviously fail, but the MAME menu items appear in the PiPLAY menu and the "Install MAME" item is removed, preventing the user from trying the install script again through the menu.

ssilverm commented 10 years ago

good catch! fixing that now.

ssilverm commented 10 years ago

Fixed.