ssilverman / QNEthernet

An lwIP-based Ethernet library for Teensy 4.1 and possibly some other platforms
GNU Affero General Public License v3.0
86 stars 24 forks source link

`client.connect` should return true or false #74

Closed JAndrassy closed 5 months ago

JAndrassy commented 5 months ago

Hello. the Arduino Ethernet library has client.connect() documentation fixed. https://www.arduino.cc/reference/en/libraries/ethernet/client.connect/

Returns true if the connection succeeds, false if not.

please consider aligning the client.connect method in your library with other Arduino networking libraries

ssilverman commented 5 months ago

That’s because I filed a bug report on the site last week. :)

It’ll be updated to match the new site contents. Thanks for following up. (They were supposed to tell me when it changed, but I hadn’t received notification yet.)

JAndrassy commented 5 months ago

yes maybe that was the cause for my PR https://github.com/arduino-libraries/Ethernet/pull/240 to be finally merged

ssilverman commented 5 months ago

Teamwork! :)