ssimms / pdfapi2

Create, modify, and examine PDF files in Perl
Other
15 stars 20 forks source link

Fix ambiguous call to "open" #18

Closed gquipster closed 7 years ago

gquipster commented 7 years ago

This module exports method "open" and also uses CORE::open to open the file handle. This results in warnings of:

Ambiguous call resolved as CORE::open(), qualify as such or use & at /usr/local/share/perl/5.18.2/PDF/API2/Basic/PDF/File.pm line 726.

Explicitly qualify the open to suppress this warning

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 53.951% when pulling 8c535200cdf0fe10f2963fe997f403333eea3bd2 on gquipster:Fix-ambiguous-call-to-"open" into 454e54329d07c72e788459ef06d7265fd9efa17c on ssimms:master.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 53.951% when pulling 8c535200cdf0fe10f2963fe997f403333eea3bd2 on gquipster:Fix-ambiguous-call-to-"open" into 454e54329d07c72e788459ef06d7265fd9efa17c on ssimms:master.

ssimms commented 7 years ago

Thanks for the pull request. I've updated the code in response to someone else's report, so I'm going to close this one.