Eliminate warnings about depricated assignment to @_

ssimms / pdfapi2

Create, modify, and examine PDF files in Perl

Other

15 stars 20 forks source link

Eliminate warnings about depricated assignment to @_ #23

Closed robbiebow closed 4 years ago

robbiebow commented 4 years ago

When used with warnings on, these two lines will emit these warnings:

Use of implicit split to @ is deprecated at /usr/local/share/perl5/PDF/API2/Content.pm line 1869 Use of implicit split to @ is deprecated at /usr/local/share/perl5/PDF/API2/Content.pm line 1925

Assigning the split to anonymous lists solves this problem. Adding the -1 third arg ensure split captures everything - not just the first match.

coveralls commented 4 years ago

Coverage increased (+0.008%) to 56.85% when pulling 3608a25ea0e32ffbfe2f0c20ded2ec317a455bc0 on robbiebow:master into fcc73b15b2e1b837a42689e1294be6868107e8b8 on ssimms:master.

PhilterPaper commented 4 years ago

This sounds like it's the same issue as bug RT 123722 (https://rt.cpan.org/Public/Bug/Display.html?id=123722).

robbiebow commented 4 years ago

I agree. It does. I see no harm in patching it for < 5.12.0 installations.