search

ssitu / ComfyUI_UltimateSDUpscale

ComfyUI nodes for the Ultimate Stable Diffusion Upscale script by Coyote-A.
GNU General Public License v3.0
875 stars 59 forks source link

Feature request: support custom sampler #76

Closed frankyifei closed 5 months ago

frankyifei commented 6 months ago

New sampler and schedulers emerging quickly, is it possible to make ultimateSDUpscale support these new techniques, such as TCD sampler, AlignYourSteps schedulers, restart scheduler and others.

ssitu commented 6 months ago

So you want a node input for custom sampler nodes?

frankyifei commented 6 months ago

yes, it would be great if it can use custom sampler. I understand it is current using common_sampler, is it going to be lots of work supporting this?

ssitu commented 6 months ago

Probably not, I'll see what I can do

ethanfel commented 6 months ago

Probably not, I'll see what I can do

hey, if possible could you do the same for the scheduler (sigmas ?) AlignYourSteps isn't usable atm with ultimate upscale. This scheduler would be super useful with it.

ssitu commented 6 months ago

So just add inputs for a custom sampler and custom sigmas? And which approach is more preferable: adding them as optional inputs vs making new nodes for them?

ethanfel commented 5 months ago

So just add inputs for a custom sampler and custom sigmas? And which approach is more preferable: adding them as optional inputs vs making new nodes for them?

I believe both ways work. I would probably choose a new node myself. Following Comfyui arrangement with the regular ksampler without the inputs and the 2 samplercustoms with inputs.

tilktilk5 commented 5 months ago

ive been yearning for this feature since custom schedulers became a thing. i would love a "sigmas" input.

gobshyte commented 5 months ago

Oh yeah I was just looking to see if I could use AYS scheduler with this, so yes please!

ssitu commented 5 months ago

Alright, a new node has been added for this. Let me know if there are any issues/suggestions with the new one or any bugs that may have appeared with the old nodes.

gobshyte commented 5 months ago

Excellent, but... can I use this new node in place of SD Upscale (No Upscale) ? At the moment I am testing with an upscaler connected but with upscale set to 1.0 instead, and hoping that mimics the behaviour of the No Upscale node but alowing custom sampler/sigmas

ssitu commented 5 months ago

I think I'll make the upscale model optional, so it will skip the upscale if it's not provided.

ethanfel commented 5 months ago

I think I'll make the upscale model optional, so it will skip the upscale if it's not provided.

thanks for the update, it's great