search

ssitu / ComfyUI_restart_sampling

ComfyUI nodes for restart sampling based on the paper "Restart Sampling for Improving Generative Processes"
GNU General Public License v3.0
83 stars 6 forks source link

Add some preset restart samplers to builtin sampler list #19

Open blepping opened 6 months ago

blepping commented 6 months ago

you thought you were free, but i'm back!

it's possible to add samplers to the list. might be useful to be able to use restart sampling in places where it's not currently possible like FaceDetailer or i guess stuff like the tiled sampler, efficient samplers, stuff like that.

the presets i added are just for demonstration, not necessarily what would be best to actually use. presets would be added to the list like restart_heun_a1111_karras.

unfortunately the GUI progress isn't correct this way, and i don't think it's really possible to fix easily. so the main downside of this approach would be that it would always be a bit janky to use (but purely a cosmetic thing).

ssitu commented 6 months ago

Haha, glad to have you back from that long break! I was getting worried.

The idea is fine, but shouldn't those nodes have a custom sampler input instead? I feel like this extension might be doing too much?

blepping commented 6 months ago

The idea is fine, but shouldn't those nodes have a custom sampler input instead? I feel like this extension might be doing too much?

i think you might be misunderstanding. this is just adding restart presets to the built in sampler list, there are no new nodes.

image

i have way too many samplers enabled, but you get the idea. :)

ssitu commented 6 months ago

I understood the feature. So facedetailer, tiled sampler, and other similar nodes don't support custom samplers?

blepping commented 6 months ago

oh, sorry. i misinterpreted where you said "those nodes". i agree that they should be more flexible but unfortunately there are quite a few custom samplers that limit you to choosing from the built in list and don't provide a custom version.

hopefully it goes without saying, but you shouldn't feel any pressure/obligation from this pull. just seeing if you were interested. i am also an add, add, add features kind of person so given free rein i'd add the kitchen sink if i could.

this also doesn't have to be done here, node collections can import other node collections so if i want to i could make a separate feature that pulls in restart sampling and adds the samplers to the list.

ssitu commented 5 months ago

I'm just being nitpicky, I think it's a fine addition.