search

ssj71 / OSC2MIDI

A highly flexible and configurable OSC to JACK MIDI (and back) bridge
GNU General Public License v3.0
46 stars 7 forks source link

Jack internal #39

Closed ssj71 closed 5 years ago

ssj71 commented 5 years ago

@agraef I don't know if you care to review these changes or not. I would like to use osc2midi on the MOD ecosystem which will require using the jack internal client API rather than the typical external standalone jack client API. In preparations for this I've made the commits here. I still have a fair bit to do and probably personally wouldn't merge it until my feature is complete, but it may be a large diff and this is hopefully more digestible. If you aren't worried about it, then I'll just charge forward and get the feature done. Or on the other hand if even this is too much, I can relatively easily break this much up into several PRs.

Importantly I expect no user-noticeable changes to osc2midi from this. I am considering moving build systems, but regardless I am making a 2nd target, so no planned feature adds, changes, or breakage for current users. The new target only presents a different ABI to jack. Please let me know your input on these matters if any. Thanks! :)

agraef commented 5 years ago

I must confess that I haven't looked at the new code yet, but as long as there are no user-visible changes, I'd say go for it.

I'm curious, though, what a typical use case for osc2midi on the MOD might be? I still have a MOD Duo lying around here which I haven't used much for quite some time, so I might want to give it a go myself. :)

Also, I'd appreciate a quick heads-up if you do make user-visible changes to the build system, so that I can update the osc2midi-git Arch package on the AUR that I maintain. (And if you do a new release, I'd then also have to notify David Runge who has adopted the stable osc2midi package and put it into the Arch community repo.)

ssj71 commented 5 years ago

sounds good. The Cmake isn't really broken, I've just come to really prefer meson. I'll see if I can get it to work without too much fighting. I'll definitely keep you in the loop.

The use case for mod is basically using a phone or tablet to control effects. Android -> osc -> bluetooth -> mod -> osc2midi -> midi learn on mod-host. There were some users asking for it and I think it will be convenient in a lot of ways for my own workflow so I'm digging into it.