ssj71 / rkrlv2

Rakarrack Effects Ported to LV2 Plugins
GNU General Public License v2.0
53 stars 10 forks source link

wet/dry mix should be post effect #7

Closed ssj71 closed 8 years ago

ssj71 commented 8 years ago

make a common function to do wet/dry mix, panning, and LR mix also change "LR cross" label to "mix L/R"

brummer10 commented 8 years ago

also change "LR cross" label to "mix L/R"

Why would you, in fact it is a Cross, you can move the applied effect from one side to the other. Or would you leave it as it is, in the other effects?

ssj71 commented 8 years ago

@brummer10 currently it's labeled "LR Crossover" which doesn't seem right. Maybe "LR Crossmix"? I'll probably change them all to be consistent

brummer10 commented 8 years ago

Maybe "LR Crossmix"?

Not bad, . . and true, a label change will indicate that something have changed behind the scene.

ssj71 commented 8 years ago

I've decided to leave these labels and in general all the processing unless its really a bug like it was in stereoharm. I am going to do some deep refactors and this will be one of the things, but it will be in a separate v2 project.