sskaje / mqtt

MQTT Client class
https://sskaje.me/category/MQTT/
MIT License
86 stars 33 forks source link

do_publish is public : is it wanted ? #8

Closed dethegeek closed 8 years ago

dethegeek commented 8 years ago

Hi

I'm beginning to replace a MQTT library lacking QoS. It seems promising; thank you very much.

I noticed the methods do_subscribe() and do_unsubscribe() are protected, whereas do_publish() is public.

I wanted to point it out as I believe is is maybe intended to be protected too.

sskaje commented 8 years ago

I guess i may have missed it. do_publish was set public while I was trying to write some test scripts before publish_sync/async.

2.0 is still not stable. If you don't mind, I'll let do_publish stay public and this issue open for some time.

Thank you.

sskaje

dethegeek commented 8 years ago

I close this for you. Thanks !