codecov[bot]
commented
3 years ago Codecov Report
Merging #151 (7455c49) into develop (4bc076a) will increase coverage by
0.02%. The diff coverage is100.00%.
@@ Coverage Diff @@
## develop #151 +/- ##
===========================================
+ Coverage 90.87% 90.89% +0.02%
===========================================
Files 51 52 +1
Lines 1479 1483 +4
Branches 126 126
===========================================
+ Hits 1344 1348 +4
Misses 121 121
Partials 14 14 | Impacted Files | Coverage Δ | |
|---|---|---|
| servicex/resources/internal/add_file_to_dataset.py | 100.00% <ø> (ø) |
|
| ...rvicex/resources/internal/file_transform_status.py | 32.00% <ø> (ø) |
|
| servicex/resources/internal/fileset_complete.py | 100.00% <ø> (ø) |
|
| servicex/resources/internal/preflight_check.py | 100.00% <ø> (ø) |
|
| servicex/resources/internal/transform_start.py | 96.29% <ø> (ø) |
|
| ...ex/resources/internal/transformer_file_complete.py | 100.00% <ø> (ø) |
|
| servicex/resources/transformation/errors.py | 100.00% <ø> (ø) |
|
| servicex/resources/transformation/get_all.py | 100.00% <ø> (ø) |
|
| servicex/resources/transformation/get_one.py | 100.00% <ø> (ø) |
|
| servicex/resources/transformation/submit.py | 96.22% <ø> (ø) |
|
| ... and 5 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 4bc076a...7455c49. Read the comment docs.
This PR organizes the API resources into directories:
servicex/resources/internal(new) contains all "internal" routes used by other microservicesservicex/resources/transformation(new) contains external routes related to transformation requestsservicex/resources/users(existing) contains external routes related to the user management systemThere is also some trivial refactoring:
transform_status.pycontained both an internal endpoint and an external endpoint so it was split into two files, and several modules were renamed to cut down on path lengths and redundant information.There is still a considerable amount of potential cleanup in the API codebase to make it properly RESTful, but this is a start.