search

ssl-hep / ServiceX_App

REST Front End to ServiceX
BSD 3-Clause "New" or "Revised" License
3 stars 10 forks source link

Add support for external minio object stores #154

Closed sthapa closed 2 years ago

sthapa commented 2 years ago

PR adds support for using an external minio object store

codecov[bot] commented 2 years ago

Codecov Report

Merging #154 (24bdf08) into develop (123265e) will increase coverage by 0.07%. The diff coverage is 72.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #154      +/-   ##
===========================================
+ Coverage    90.89%   90.96%   +0.07%     
===========================================
  Files           52       52              
  Lines         1483     1495      +12     
  Branches       163      164       +1     
===========================================
+ Hits          1348     1360      +12     
  Misses         121      121              
  Partials        14       14
Impacted Files Coverage Δ
servicex/transformer_manager.py 91.78% <69.56%> (+0.80%) :arrow_up:
servicex/object_store_manager.py 100.00% <100.00%> (ø)
servicex/resources/transformation/submit.py 96.19% <100.00%> (-0.04%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 123265e...24bdf08. Read the comment docs.

ivukotic commented 2 years ago

I just tested it and it works.