search

ssl-hep / ServiceX_App

REST Front End to ServiceX
BSD 3-Clause "New" or "Revised" License
3 stars 10 forks source link

pin MarkupSafe to 2.0.1 #164

Closed sthapa closed 2 years ago

sthapa commented 2 years ago

MarkupSafe 2.1.0 breaks the build due to deprecated function removal

sthapa commented 2 years ago

Okay, this is a clean PR.

soft_unicode was removed from MarkupSafe in 2.1.0. Pin to a working version. See https://github.com/ssl-hep/ServiceX_App/runs/5326186779?check_suite_focus=true for a test run where this caused a failure

codecov[bot] commented 2 years ago

Codecov Report

Merging #164 (fa9ad5a) into develop (f60a9ba) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #164   +/-   ##
========================================
  Coverage    90.63%   90.63%           
========================================
  Files           50       50           
  Lines         1442     1442           
  Branches       158      158           
========================================
  Hits          1307     1307           
  Misses         121      121           
  Partials        14       14

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f60a9ba...fa9ad5a. Read the comment docs.