Closed ponyisi closed 2 months ago
Attention: Patch coverage is 92.30769%
with 1 line
in your changes missing coverage. Please review.
Project coverage is 81.61%. Comparing base (
07b7296
) to head (bed3d0f
). Report is 1 commits behind head on 3.0_develop.
Files with missing lines | Patch % | Lines |
---|---|---|
servicex/func_adl/func_adl_dataset.py | 0.00% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Hold off on a merge, I'm trying to fix something...
OK, we can continue. I had to remove the redundant string regex validation in the model definition, because that broke the enum coercion; it should be OK because the allowed enum values provide the validation.
ResultFormat
andOutputFormatEnum
: the latter is now used in theServiceXSpec
and is translated to aResultFormat
when creating the actual request, so that the string sent to the server is stillroot-file
.Important Note: The
ResultFormat
is still what you get back from the server, though, so the cache will continue to handleroot-file
and notroot-ttree
. If at some point we change this string it'll have the side-effect of invalidating caches.