ssl-hep / ServiceX_frontend

Client access library for ServiceX
https://servicex-frontend.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
5 stars 11 forks source link

Reduce library dependencies (addresses #432) #436

Closed ponyisi closed 2 months ago

ponyisi commented 2 months ago

Make pandas a dependency only of tests (where it gets used to interpret data), remove references to it from the main library, remove the pandas extra.

Also remove the databinder extra because the package it installs (nest-asyncio) is not actually invoked.

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 81.66%. Comparing base (07b7296) to head (225c484). Report is 2 commits behind head on 3.0_develop.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## 3.0_develop #436 +/- ## =============================================== + Coverage 81.54% 81.66% +0.11% =============================================== Files 26 26 Lines 1349 1336 -13 =============================================== - Hits 1100 1091 -9 + Misses 249 245 -4 ``` | [Flag](https://app.codecov.io/gh/ssl-hep/ServiceX_frontend/pull/436/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ssl-hep) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/ssl-hep/ServiceX_frontend/pull/436/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ssl-hep) | `81.66% <ø> (+0.11%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ssl-hep#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.