codecov[bot]
commented
2 months ago Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 82.71%. Comparing base (
daed1b1) to head (91e4573). Report is 3 commits behind head on 3.0_develop.
Additional details and impacted files
```diff @@ Coverage Diff @@ ## 3.0_develop #439 +/- ## =============================================== + Coverage 81.73% 82.71% +0.98% =============================================== Files 26 26 Lines 1341 1423 +82 =============================================== + Hits 1096 1177 +81 - Misses 245 246 +1 ``` | [Flag](https://app.codecov.io/gh/ssl-hep/ServiceX_frontend/pull/439/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ssl-hep) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/ssl-hep/ServiceX_frontend/pull/439/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ssl-hep) | `82.71% <ø> (+0.98%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ssl-hep#carryforward-flags-in-the-pull-request-comment) to find out more.:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Address #295 by only verifying that we only list the S3 buckets when we have a cached record if we are trying to get local files when only signed URLs are cached, or vice versa. Fix a number of tests.