ssl-hep / ServiceX_frontend

Client access library for ServiceX
https://servicex-frontend.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
5 stars 11 forks source link

Fix for colors with multiple progress bars #459

Closed ponyisi closed 2 months ago

ponyisi commented 2 months ago

When there are several in-flight transformations, a failure in one would cause all progress bars to be marked as red (until they completed). This is misleading; transforms that have not failed should still be green. This fix makes only the broken transforms show up as red.

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 82.06442% with 245 lines in your changes missing coverage. Please review.

Project coverage is 82.06%. Comparing base (1b1c19c) to head (394b3fa). Report is 7 commits behind head on master.

Files with missing lines Patch % Lines
servicex/app/transforms.py 50.00% 51 Missing :warning:
servicex/app/cache.py 0.00% 39 Missing :warning:
servicex/func_adl/util.py 13.95% 37 Missing :warning:
servicex/func_adl/func_adl_dataset.py 68.75% 30 Missing :warning:
servicex/app/main.py 0.00% 20 Missing :warning:
servicex/configuration.py 76.38% 17 Missing :warning:
servicex/app/codegen.py 0.00% 16 Missing :warning:
servicex/func_adl/func_adl_dataset_group.py 0.00% 16 Missing :warning:
servicex/servicex_client.py 94.54% 9 Missing :warning:
servicex/expandable_progress.py 91.66% 7 Missing :warning:
... and 2 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #459 +/- ## ========================================== + Coverage 80.14% 82.06% +1.91% ========================================== Files 26 26 Lines 1355 1366 +11 ========================================== + Hits 1086 1121 +35 + Misses 269 245 -24 ``` | [Flag](https://app.codecov.io/gh/ssl-hep/ServiceX_frontend/pull/459/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ssl-hep) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/ssl-hep/ServiceX_frontend/pull/459/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ssl-hep) | `82.06% <82.06%> (+1.91%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ssl-hep#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.