codecov[bot]
commented
2 months ago Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 82.75%. Comparing base (
e681796) to head (4c0a363). Report is 15 commits behind head on 3.0_develop.
Additional details and impacted files
```diff @@ Coverage Diff @@ ## 3.0_develop #470 +/- ## =============================================== + Coverage 82.32% 82.75% +0.43% =============================================== Files 26 26 Lines 1386 1386 =============================================== + Hits 1141 1147 +6 + Misses 245 239 -6 ``` | [Flag](https://app.codecov.io/gh/ssl-hep/ServiceX_frontend/pull/470/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ssl-hep) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/ssl-hep/ServiceX_frontend/pull/470/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ssl-hep) | `82.75% <ø> (+0.43%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ssl-hep#carryforward-flags-in-the-pull-request-comment) to find out more.:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
ketan96-m
Resolves #464
Bug:
The marching ants seems to take the first number back from SX and report that for the complete run (rather than updating):
Solution:
There was a bug in the implementation of the update code of progress bar. Fixed it to take the total files from the backend.
Added a test case for advancing the progress bar.