Closed ketan96-m closed 2 weeks ago
I'm a bit unsure which errors you think should and shouldn't be caught here? I guess you mean that the RetryClient
shouldn't try to retry anything except HTTP connection problems?
So I'm not really sure what there is to do here, and I'd be inclined to close it and move on. There is an issue I can see (and which @ketan96-m refers to in his traceback) which is that we implicitly assume that all responses from the server will be in JSON; certainly for 500-class errors this is not true, and so we will wind up raising unrelated exceptions, which have a chance of getting propagated to the user. Those could be a 3.0.2 fix.
Anyone objecting to me closing this issue, speak now...
Follow up on the PR: https://github.com/ssl-hep/ServiceX_frontend/pull/469 Allow only ClientError exception handling. Currently handles RuntimeError.
Add ClientError to
retry_options
e.g log