Closed ketan96-m closed 1 month ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 83.52%. Comparing base (
0487232
) to head (97dbb29
). Report is 2 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Could you add a test for the specific code path that codecov is complaining about? Then I'll approve
@ponyisi @gordonwatts ready for review The unit tests were a piece to get it working!
Problem
Resolve #375
When the user submits a transform without
ignore-cache
-> records are inserted as expected When the user submits same transform withignore-cache
-> a NEW record is still created (tiny db has no unique value contraints) When the user submits same tranform withoutignore-cache
-> 2 records are present hence raises exceptionFix
When the user submits a query and selects ignore_cache - Check if we have a previous hash already present and if present delete that record since we are going to run the transform again.