ssleert / zfxtop

[WIP] fetch top for gen Z with X written by bubbletea enjoyer
BSD 2-Clause "Simplified" License
367 stars 13 forks source link

Temp is 0 for AMD k10temp #2

Closed ferrreo closed 1 year ago

ferrreo commented 1 year ago

As above, it's reading 0 for AMD for temps.

I can read the temp myself at: /sys/class/hwmon/hwmon6/temp1_input

I think line 292 of depend.go needs to be something like

if string(f) == "coretemp\n" || string(f) == "k10temp\n" {

Though after taking a second look I don't think the averaging code is correct as k10temp provides temps for each CCD as well as the hotspot temp so averaging them isn't correct. Should just take the hotspot (Tctl in the _label file).

image

ssleert commented 1 year ago

I'll fix it tomorrow.

ferrreo commented 1 year ago

Created a PR https://github.com/ssleert/zfxtop/pull/14 to fix the temp values being averaged incorrectly

Lucas-101 commented 1 year ago

Close?