fix: rendering for multiple key options

ssleptsov / ninja-keys

Keyboard shortcuts interface for your website. Working with static HTML, Vanilla JS, Vue, React, Svelte.

https://ninja-keys-demo.vercel.app/

MIT License

1.65k stars 60 forks source link

fix: rendering for multiple key options #29

Closed oddcelot closed 2 years ago

oddcelot commented 2 years ago

This also improves some a11y for the actual keys with the <kbd> element

(Also had to upgrade lit for the join()to work, which I think should have been supported by v 2.0.2)

oddcelot commented 2 years ago

Just FYI: here's a playground (always makes it a bit easier to check it out 😸 ) Maybe try out also the hotKeysJoinedView option for comparison

ssleptsov commented 2 years ago

Hey @oddcelot Thank you so much for PR, looks good! It's published with version 1.2.2 Also, appreciate a playground too! Really sorry for late response, I have some limited time right now...

oddcelot commented 2 years ago

@ssleptsov No worries, this is the nature of OSS afterall 😄 And thanks for reviewing. Really appreciate the time you spent. If you need any help, let me know. Liking this quite a bit 🙃